Make sure we are closing our DB connections! - Githubissues

betheluniversity / directory

A pythonic remake of the infamous directory.bethel.edu

0 stars 0 forks source link

Make sure we are closing our DB connections! #102

Closed c-schwarze closed 4 years ago

c-schwarze commented 4 years ago

Description

Dave mentioned to me that our banweb account was creating heavy usage for the DB. It was all from me running the directory locally.

Size and Type of change

Small Change - 1 person needs to review this
Bug fix

How Has This Been Tested?

I tested this locally to make sure everything was running as expected
I also started/stopped my local instance a few times. I then doubled checked with Dave and his logs that it wasn't creating problems!

Checklist:

Only check what applies and what you have done.

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have tested on multiple browsers (Chrome, Firefox, Safari, IE suite)

c-schwarze commented 4 years ago

@josiahtillman we are not longer using conn_bw in app.db.db_connection_bw. I suppose we could just change it all to conn instead of conn_bw. I'll go ahead and do that to reduce confusion either way!