Closed bethgrace5 closed 8 years ago
After I finish everything Im going to do extreme polishing
All is done I think, I just need to fix the html to look better. I need to learn about web design
@tpascua11 great work so far! I have a few nit-pickey suggestions for you.
defaultDate()
. Change the format string to "MMMM Do, YYYY", and call this function everywhere you display dates in request view.totalDays()
seems to always return one less day than the time span actually is. If a request is from the 4th of March to the 4th of March (same day) it should be one day, not zero. If a request is from the 9th of March to the 12th of March, it should be 4 days. (also totalDays()
has some oddly named variables that are not really intuitive. consider renaming them to start and end or first and last.getEmployees()
in request.js that is essentially a copy of the one in main.js. Remember that your request controller can "see" any variables in the main controller. This means that you don't need a separate copy of the employee list in request.js, you can just reference the one in main.js. - put simply, 1. delete that function in request.js, and 2. delete that declaration for employees in request.js.pending
requests should not show up in the request history list. Those are already shown above in the pending list.
I don't think that requests that were already approved or denied should be able to change status once they've been answered.