This is bad form - I want to review it before I pull, but I haven’t written unit tests.
I won’t close this until the tests are written, but I can get a lot of value from even buggy code in this respect.
This was a big piece of work, and the pull deserves better notes:
includes a new set of db tables:
EvalClassQuestion = the thing that controls what questions get asked
EvalClass - comment, grade, boolean - 3 ways of taking in the answer and connecting it to the person, the question and the class.
a new thread set - to get and set the eval questions.
updates to numerous class visualization places - personal schedule online, calendar, class list, class detail - to show the user a speedometer when they are eligible to rate the class. Teachers cannot rate their own class and a class cannot be rated by a given user more than once.
In doing all this, I had to refactor some other stuff that is worth noting:
the way we did a horizontal check list was a massively bad idea - when we overwrite a template fo a form field, it overwrites it permanently for all types of the parent. Corrupting the times when you wanted it the original way. I fixed ALL cases of that.
I refactored scheduler models to have a models folder and a remains.py, it's time to bring that up to par with GBE.
as long as I was screwing with the DB I removed acts from shows - it's a dead table.
the way we show the icon and then guide the user to login and make a profile is the same as interests, so I refactored that code for reusability
This is bad form - I want to review it before I pull, but I haven’t written unit tests.
I won’t close this until the tests are written, but I can get a lot of value from even buggy code in this respect.
This was a big piece of work, and the pull deserves better notes:
includes a new set of db tables:
a new thread set - to get and set the eval questions.
updates to numerous class visualization places - personal schedule online, calendar, class list, class detail - to show the user a speedometer when they are eligible to rate the class. Teachers cannot rate their own class and a class cannot be rated by a given user more than once.
In doing all this, I had to refactor some other stuff that is worth noting: