search

beto-rodriguez / LiveCharts2

Simple, flexible, interactive & powerful charts, maps and gauges for .Net, LiveCharts2 can now practically run everywhere Maui, Uno Platform, Blazor-wasm, WPF, WinForms, Xamarin, Avalonia, WinUI, UWP.
https://livecharts.dev
MIT License
4.38k stars 572 forks source link

Refactor access modifiers in base classes #1609

Closed jaybyrd42 closed 4 weeks ago

jaybyrd42 commented 2 months ago

Add possibility to override OnMouseDown, OnMouseUp and other related event handlers and reuse logic from those overriden methods in Classes derived from LiveChartsCore.Chart by changing InvokePointerDown, InvokePointerMove, InvokePointerUp, InvokePointerLeft... access modifiers to protected internal

jaybyrd42 commented 2 months ago

Possibly refactor all internal modifers to protected internal.

Having internal access modifiers when using this library as Nuget package hinders modification

beto-rodriguez commented 1 month ago

I like this idea; I changed most of the internal methods to protected internal (at least the methods that make more sense).

This will be included in the next version, I hope this is enough, but let me know if something is not accessible enough.