search

betodealmeida / gsheets-db-api

A Python DB-API and SQLAlchemy dialect to Google Spreasheets
MIT License
212 stars 16 forks source link

strip blank columns #12

Closed nytai closed 4 years ago

nytai commented 4 years ago

Sometimes google returns blank columns (ie '') in the results. This is most likely caused by edits to the columns at some point. Most programs assume that database column names are not blank so often select * from ... queries fail. This PR removes any blanks columns, and the associated row data, from the final results and description.

codecov-io commented 4 years ago

Codecov Report

Merging #12 into master will increase coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   72.38%   72.47%   +0.08%     
==========================================
  Files          16       16              
  Lines         927      930       +3     
==========================================
+ Hits          671      674       +3     
  Misses        256      256
Impacted Files Coverage Δ
gsheetsdb/convert.py 100.00% <100.00%> (ø)
gsheetsdb/query.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe90abe...a6b28d1. Read the comment docs.

betodealmeida commented 4 years ago

Awesome! Thanks, @nytai! I'll merge and make a new release.