betodealmeida / shillelagh

Making it easy to query APIs via SQL

MIT License

374 stars 50 forks source link

fix: use better JSONPath library #431

Closed betodealmeida closed 4 months ago

betodealmeida commented 4 months ago

Summary

Use python-jsonpath instead of jsonpath-python, since it handles the root ($) better.

Testing instructions

cwegener commented 4 months ago

How does it compare to jsonpath-ng ? https://github.com/h2non/jsonpath-ng

betodealmeida commented 4 months ago

How does it compare to jsonpath-ng ? https://github.com/h2non/jsonpath-ng

Ah, I wasn't aware of that library. Looks like a nice solution, and it handles the root path correctly.

cwegener commented 4 months ago

How does it compare to jsonpath-ng ? https://github.com/h2non/jsonpath-ng

Ah, I wasn't aware of that library. Looks like a nice solution, and it handles the root path correctly.

It's been in use in https://github.com/meltano/sdk and I've used that one quite a bit and it does the job.