betodealmeida / shillelagh

Making it easy to query APIs via SQL
MIT License
387 stars 52 forks source link

GitHub adapter broken #449

Closed betodealmeida closed 2 months ago

betodealmeida commented 5 months ago

The GitHub adapter handlers LIMIT and OFFSET, but leaves the filtering to apsw, which means fewer rows might be returned.

To make things worse, the test tests/adapters/api/github_test.py::test_github_json_field started failing, because it seems like apsw no longer filters when the adapter handles the LIMIT, so it's returning data that doesn't match the predicate in the query.