betr-io / terraform-provider-mssql

Terraform provider for Microsoft SQL Server
https://registry.terraform.io/providers/betr-io/mssql/latest
MIT License
35 stars 28 forks source link

Unclear documentation #27

Open hoses-h opened 2 years ago

hoses-h commented 2 years ago

Hello,

My name is Héctor.

I have recently had to solve an issue with creating users with the resource configuration mssql_user.

Specifically, I have had to add the parameter object_id to this resource configuration while there is no place in the documentation that indicates this parameter is optional; only there is this sentence that indicates the posibility of using object id (not object_id as a parameter). "Note that in order to create an external user referencing an Azure AD entity (user, application), the Azure SQL Server needs to be a member of an Azure AD group assigned the Azure AD role Dictionary Reader. If it is not possible to give the Azure SQL Server this role (through the group), you can use the object id of the Azure AD entity instead."

I have also encountered another issue that I am not sure if it is related to the previous one. The parameter object_id should be defined, supposedly, inside the login block but I get an error when I define it like that in a module and I have had to comment this parameter for the module to run.

Thank you.

Regards.

magne commented 2 years ago

The object_id attribute is documented in the login block.

If you feel the documentation is unclear (which it most probably is :smile:), please consider submitting a PR, @hoses-h.