Consider renaming "modified" to "$modified"

betsol / angular-input-modified

Angular.js module to detect and indicate input modifications

90 stars 35 forks source link

Consider renaming "modified" to "$modified" #34

Closed jrharshath closed 7 years ago

jrharshath commented 8 years ago

This is only a suggestion. Since:

since we're modifying ng-model's native behaviour
not declaring a new directive
calling the module ngInputModified instead of something that's not in angular's namespace (like bsInputModified)
overriding the way $pristine is set to account for modified (again affecting angular's standard behaviour)

I propose we call our flag $modified. It would feel like a very fluid extension of angular's capabilities this way.

Let me know what you think!

slavafomin commented 8 years ago

Yes, Harshath. That makes sense. However, I'm not yet sure in what direction should we move - to make this module closer to the Angular.js codebase or to make it a more independent third-party extension. We'll think about it, if we'll decide to make a 3.0 release.

jrharshath commented 8 years ago

Perhaps convert this into a PR for angularjs first, and then see how it turns out? :smile:

jrharshath commented 8 years ago

Angular already finds this feature wanting - check out this issue.

https://github.com/angular/angular.js/issues/11289

slavafomin commented 7 years ago

I've decided to stick to the current naming scheme for now. We should interfere with Angular namespace as little as possible.