search

betsol / angular-input-modified

Angular.js module to detect and indicate input modifications
90 stars 35 forks source link

Bug with angular 1.6.1 #50

Closed BenevidesLecontes closed 7 years ago

BenevidesLecontes commented 7 years ago

After upgrading from angular 1.5.10 to angular 1.6.1, i noticed this error: TypeError: Cannot set property '$dirty' of null, because this line

// Calling overloaded method.
originalSetPristine.apply(this, arguments);

So, i changed the line above to this and everything is working fine

if (this) {originalSetPristine.apply(this, arguments);}
trimox commented 7 years ago

Thanks!

brunowego commented 7 years ago

@BenevidesLecontes please make a pull request 👍

BenevidesLecontes commented 7 years ago

@brunowego i'll do soon i can.

slavafomin commented 7 years ago

Hello! Thank you everyone for noticing this issue. I'm sorry I wasn't been able to fix it sooner.

It's fixed now in patch level immediate releasev2.3.4. Feel free to try it out and let me know if it needs further attention.

Cheers!

slavafomin commented 7 years ago

Also, be advised, that solution provided by @BenevidesLecontes is incorrect and probably breaks some functionality. I would recommend to update as soon as possible if you were using it.