betsyCC / OAREDA_Syntax_Library

MIT License
1 stars 7 forks source link

Update to include most recent Fall-term 1-Semester Ret data #18

Closed be1ink closed 4 months ago

be1ink commented 4 months ago

Updated EXTRACT(YEAR FROM ADD_MONTHS(SYSDATE,0)) code on three lines to set the ADD_MONTHS second argument value to 0 from -12 (retention institution and system numerator 1-semester calculations) and -24 (at the WHERE clause).

betsyrosalen commented 4 months ago

Hi @be1ink,

This is basically the same thing I did but I don't want to change it here in the syntax library because this is the public databook version of the SQL. The internal version is a bit different and we include things that are not in the public version. That is the one that I updated that matches your numbers. Probably I should add the SQL for all the different versions in GitHub, but I didn't want to confuse anyone too much. Thanks for trying to make a contribution to the syntax library though! Keep it coming!

betsyrosalen commented 4 months ago

Closing this without merging.

be1ink commented 4 months ago

@betsyrosalen ah, that makes sense! I appreciate you reviewing the proposed code. Glad that the push request got through!