Closed robmclear closed 8 months ago
Are you requesting that they should be both LAST FIRST, or both FIRST LAST ?
Every system I’ve ever used has displayed patient names as LAST FIRST, so that would be my recommendation.
-Rob
On Mar 18, 2024, at 9:43 AM, Alex Bettarini @.***> wrote:
Are you requesting that they should be both LAST FIRST, or both FIRST LAST ? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>
Thank you for the clarification. I started investigating the issue, which is remotely related to issue #91. If you expect the order to be LAST FIRST, you are saying the Query results are wrong. Can you please post a screenshot of one of the other systems that you've ever used, showing the result for the SAME Query that you posted above ? I'm asking you this because I suspect that some servers don't encode the Patient Name correctly, for example they might put "GivenName FamilyName" in the field reserved to the FamilyName.
Happy to help. Attached are images of queries from two unrelated servers hosted by different companies using the current versions of Horos and Miele, demonstrating the issue.
-Rob

On Mar 19, 2024, at 5:55 AM, Alex Bettarini @.***> wrote:
Thank you for the clarification. I started investigating the issue, which is remotely related to issue #91 https://github.com/bettar/miele-lxiv/issues/91. If you expect the order to be LAST FIRST, you are saying the Query results are wrong. Can you please post a screenshot of one of the other systems that you've ever used, showing the result for the SAME Query that you posted above ? I'm asking you this because I suspect that some servers don't encode the Patient Name correctly.
— Reply to this email directly, view it on GitHub https://github.com/bettar/miele-lxiv/issues/115#issuecomment-2006590359, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTBPSMRCI7R4G5NCO36S7DYZADS3AVCNFSM6AAAAABE2KMMEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBWGU4TAMZVHE. You are receiving this because you authored the thread.
I received your email but there was no attachment of any screenshot.
Trying again, I don’t have access to the same servers from here today, so this is one server queried with Horos and Miele showing the difference in name order. Other servers I have checked yield the same results.
On Mar 20, 2024, at 6:53 AM, Alex Bettarini @.***> wrote:
I received your email but there was no attachment of any screenshot. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>
Again I didn't get any screenshot attachments in the email, could you try adding them from the GitHub page like you did in your first message above ?
Happy to help. Attached are images of queries from two unrelated servers hosted by different companies using the current versions of Horos and Miele, demonstrating the issue.
-Rob
The DICOM person name is structured as Person Name Components with FamilyName first.
Since issue #91 Miele-LXIV parses the person name using the DCMTK function getFormattedNameFromString for which the output format is "[namePrefix][ firstName][ middleName][ lastName][, nameSuffix]".
This is where the swap of first/last name order occurs. I agree that it is inconsistent with the table in the Database view, but hopefully it does a better parsing of more complex names, for example having all 5 components.
First and third images are Horos, second and fourth images are Miele. Apologies again, the info was in the file name but I guess it doesn't carry over when posted on Github.
The fix will be included in the next release. It will work as per your recommendation, with the additional benefit of also fixing the Query column "Institution".
In the Q/R window, patient names are listed as FIRST LAST. Once retrieved, names are listed as LAST FIRST.