Enhanced Cross-Platform Compatibility and Docker Environment Setup

better-rail / app

An alternative mobile client for Israel Railways

https://better-rail.co.il

GNU Affero General Public License v3.0

150 stars 27 forks source link

Closed YonLiud closed 3 months ago

YonLiud commented 4 months ago

Changes Made:

Added Cross-Platform Support for Yarn Installation:
- Fixed #373
- Introduced conditional logic in the Dockerfile to accommodate differences between macOS/Linux and Windows environments during yarn installation.
- Adjusted Firebase configuration steps to ensure compatibility across different operating systems (macOS/Linux vs. Windows).

I've thoroughly tested the changes on both Windows and Linux environments, and they work seamlessly.

guytepper commented 4 months ago

Hey, thanks a lot for taking the time to make this!

Looks good to me, but I'll let @planecore review this one, as he's more devops oriented than I am :)

planecore commented 4 months ago

Hi, thanks for your contribution! I'm currently abroad and don't have my laptop with me. I'll review this when I'll be back over the weekend.

planecore commented 4 months ago

Sadly I just can't get it to run on my machine. I tried to add the bin folder before the install command but still no luck.

YonLiud commented 4 months ago

I've recently made some changes to the project, and the build ran smoothly on my end. should not run with any issues on your end either

Keep me updated please!

YonLiud commented 3 months ago

I couldn't reproduce the issue, but if it worked for you, I can't argue with that.