search

better-rail / app

An alternative mobile client for Israel Railways
https://better-rail.co.il
GNU Affero General Public License v3.0
146 stars 27 forks source link

Replace `react-native-modal` with `react-native-modalfy` #382

Open guytepper opened 1 week ago

guytepper commented 1 week ago

Since react-native-modal isn't maintained anymore, we get warnings on Android related to it's reanimated usage.

Let's replace it with react-native-modalfy, which is a maintained library, and offers better performance and features.

Vivek1235 commented 1 week ago

I would like to work on this issue?

guytepper commented 1 week ago

@Vivek1235 thank you! It's yours :)

Let's do it incrementally - start with migrating the date-picker-modal.android.tsx file to the new library. After that we can proceed to the other 2 occurrences: route-list-warning.tsx and tip-thanks-modal.tsx.

guytepper commented 1 week ago

@Vivek1235 just heads up, the branch version/2.3.3 is the branch you should base your work on. main might have build issues.

If you have any questions/issues don't hesitate to reach out! 🙏

Vivek1235 commented 1 week ago

I am not able to run the project on my system

guytepper commented 1 week ago

@Vivek1235 what issue do you encounter? Please provide more details so we can help :)

Vivek1235 commented 1 week ago

Screenshot 2024-10-14 173525 I am getting this error when i try to run on ios simulator

guytepper commented 1 week ago

@Vivek1235 It's not possible to run the iOS simulator on a Windows machine. Try running Android instead, you can follow the instructions here: https://reactnative.dev/docs/set-up-your-environment?os=windows&platform=android