better / convoys

Implementation of statistical models to analyze time lagged conversions
https://better.engineering/convoys/
MIT License
258 stars 42 forks source link

handle timestamps with timezones set #108

Closed erikbern closed 5 years ago

erikbern commented 5 years ago

no reason to have to set now explicitly going forward

another minor fix that came up

coveralls commented 5 years ago

Coverage Status

Coverage increased (+1.07%) to 97.861% when pulling d3d05e36c49196d94f1f394eedfc5f45b5888295 on timezones into 263690c94d97ef2455cdb718457fbcecc21ce9b7 on master.

erikbern commented 5 years ago

realized this bug wasn't fixed, my test code was broken. will fix later.

erikbern commented 5 years ago

kind of silly that this is 40 lines of test for 3 lines of code, but whatev