Fix shape handling in .cdf

better / convoys

Implementation of statistical models to analyze time lagged conversions

https://better.engineering/convoys/

MIT License

260 stars 42 forks source link

Fix shape handling in .cdf #111

Closed erikbern closed 5 years ago

erikbern commented 5 years ago

I've recently started really enjoying the intricacies of Numpy's broadcasting rules

This changes makes shape management make a lot more sense and will solve a few issues I've seen in the past.

Not 100% backwards compatible

coveralls commented 5 years ago

Coverage increased (+0.005%) to 98.133% when pulling 3c8842a1edf57a9e7de3465272a84b0f40b332c0 on cdf-shapes into ff77f6fae9c8a72aed96b19b188821569dc1b0ef on master.