search

better / convoys

Implementation of statistical models to analyze time lagged conversions
https://better.engineering/convoys/
MIT License
254 stars 42 forks source link

n_iterations needs to be an int or generalized gamma model breaks. #131

Closed Will-So closed 2 years ago

Will-So commented 3 years ago

Hey big fan of the project.

A Numpy Call to np.empty in Emcee is unhappy since numpy 1.11 (I think) that n_iterations is a float.

np.ceil() is used to calculate the number of iterations and it returns a float. Changing the result to an int fixes Generalized Gamma as of Numpy version 1.21.2.

atlantis-for-atlantis-bettermg-com[bot] commented 3 years ago

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

erikbern commented 3 years ago

Apparently I lost write access to this but maybe @stphnma could merge?

mdagost commented 2 years ago

Also a big fan. Hitting this error. Any update on getting the fix merged in?

erikbern commented 2 years ago

@victorquinn ?

victorquinn commented 2 years ago

Sorry for the delay here!

Thanks for the ping @erikbern :)

erikbern commented 2 years ago

thanks for the fast approval and merge @victorquinn !

mdagost commented 2 years ago

Awesome! Thanks! I can confirm master is working now for me!