Rewrite Kaplan-Meier - Githubissues

better / convoys

Implementation of statistical models to analyze time lagged conversions

https://better.engineering/convoys/

MIT License

258 stars 42 forks source link

Rewrite Kaplan-Meier #33

Closed erikbern closed 6 years ago

erikbern commented 6 years ago

Don't use the lifelines implementation, just implement it ourselves.

Turns out the output of the nonparametric model and Kaplan-Meier is basically identical. I'm going to do some more testing but I'm tempted to delete the former given that it's a lot more complex/slow

coveralls commented 6 years ago

Coverage increased (+5.04%) to 91.688% when pulling cbdc979fd7474ab3c8c53f9865bde7d55291e843 on rewrite-kaplan-meier into 25ee561591badde956749864ae12ba11d9d7ff2e on master.

erikbern commented 6 years ago

I think I can get to 100% code coverage 🤣