better / convoys

Implementation of statistical models to analyze time lagged conversions
https://better.engineering/convoys/
MIT License
254 stars 42 forks source link

switch to adagrad + minibatches #35

Closed erikbern closed 6 years ago

erikbern commented 6 years ago

minibatches should be faster in theory and also lets me get rid of a bunch of extra junk

adagrad seems to improve convergence of gamma fitting a lot

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.4%) to 92.138% when pulling be5050bc25c3bbab368515626ffdd19aebc869da on minibatch-adagrad into ef01b4be0b419500299b4e3dffd4d1c9bed8c515 on master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.4%) to 92.138% when pulling be5050bc25c3bbab368515626ffdd19aebc869da on minibatch-adagrad into ef01b4be0b419500299b4e3dffd4d1c9bed8c515 on master.

erikbern commented 6 years ago

unfortunately this is as slow as hell

but seems to converge much better at least :)