search

better / convoys

Implementation of statistical models to analyze time lagged conversions
https://better.engineering/convoys/
MIT License
258 stars 42 forks source link

vectorizing time diff calc for speed boost #75

Closed stphnma closed 6 years ago

stphnma commented 6 years ago

Throwing the time diff calculation in get_arrays into an apply function for vectorization -- seemed to make it run 5x faster when I tested it locally. Not too different in terms of code, I'm guessing the T_raw.append that took the longest time

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 94.88% when pulling c9d2fa8a21c63dc2d7e7ed0705684d242d21f042 on stphnma:master into 075a3e4792495e696c52cc981da805d24cea6745 on better:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 94.88% when pulling c9d2fa8a21c63dc2d7e7ed0705684d242d21f042 on stphnma:master into 075a3e4792495e696c52cc981da805d24cea6745 on better:master.

erikbern commented 6 years ago

nice! haha just noticed you created this PR 5 min ago, was kind of random that i was checking in on github right now