Add km test - Githubissues

better / convoys

Implementation of statistical models to analyze time lagged conversions

https://better.engineering/convoys/

MIT License

254 stars 42 forks source link

Add km test #89

Closed kning closed 5 years ago

kning commented 5 years ago

Adds mock data test of kaplan meier model, similar to what we have internally.

kning commented 5 years ago

@erikbern review please. one of the hound violations i'd like to leave if cool, it's just kind of a nasty one-liner list comprehension :/.

coveralls commented 5 years ago

Coverage remained the same at 95.17% when pulling fb700f94e56c02d082c0d6ca0ff746782db8bad3 on kning:add-km-test into 6a7a1641d1701828cb0f58d08a62ae960edfb210 on better:master.

kning commented 5 years ago

also not sure why this build failed...

erikbern commented 5 years ago

It's failing on something with pytest (can you see the travis build output? not sure if you need to be authenticated)

kning commented 5 years ago

Error in the build (only for py 2.7 and py3.6, passes for py3.5 strangely enough):

The command "py.test -s -v --cov=convoys ." exited with 1.

Tests pass fine locally though.

erikbern commented 5 years ago

weird, if you can't figure it out i'll find some time later to look at this

thanks for the fix!

erikbern commented 5 years ago

Thanks @kning !