betterangels / buoy

:sos: A community-based crisis response system. Because friends don't let friends call the cops. :fire::police_car::fire:
https://betterangels.github.io/buoy/
GNU General Public License v3.0
71 stars 23 forks source link

Rewrite buoy front end using Backbone.js #185

Open hurtstotouchfire opened 7 years ago

hurtstotouchfire commented 7 years ago

This rewrite should also improve the isolation of the front end with a view to extracting it into a small JS library that would facilitate possible back-end expansion (see #171, #172). This should also at least partially obsolete #64.

Goals:

Scope:

hurtstotouchfire commented 7 years ago

please edit this. I can't remember everything we discussed.

fabacab commented 7 years ago

CC'ing @mcverter, who's expressed an interest in helping with this process, too.

fabacab commented 7 years ago

@hurtstotouchfire Have a look at #190, which is a PR for the first line item here (which I'm marking "done") because it "improves DOM spaghetti." All I've done is DRY the references to containment-level HTML ids and class attributes.

If more, what else does "improve DOM spaghetti" actually mean?

mcverter commented 7 years ago

I am working on the javascript currently

On Dec 1, 2016 11:17 PM, "Meitar M." notifications@github.com wrote:

@hurtstotouchfire https://github.com/hurtstotouchfire Have a look at

190 https://github.com/betterangels/buoy/pull/190, which is a PR for

the first line item here (which I'm marking "done") because it "improves DOM spaghetti." All I've done is DRY the references to containment-level HTML ids and class attributes.

If more, what else does "improve DOM spaghetti" actually mean?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/betterangels/buoy/issues/185#issuecomment-264369735, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYvhLP6twfl29mV9njj5yMSoMDyl7SJks5rD5vWgaJpZM4K8B3R .

mcverter commented 7 years ago

What is being done by you all? Are we working on the same code?

On Dec 1, 2016 11:18 PM, "Mitchell Verter" mitchell.verter@gmail.com wrote:

I am working on the javascript currently

On Dec 1, 2016 11:17 PM, "Meitar M." notifications@github.com wrote:

@hurtstotouchfire https://github.com/hurtstotouchfire Have a look at

190 https://github.com/betterangels/buoy/pull/190, which is a PR for

the first line item here (which I'm marking "done") because it "improves DOM spaghetti." All I've done is DRY the references to containment-level HTML ids and class attributes.

If more, what else does "improve DOM spaghetti" actually mean?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/betterangels/buoy/issues/185#issuecomment-264369735, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYvhLP6twfl29mV9njj5yMSoMDyl7SJks5rD5vWgaJpZM4K8B3R .

fabacab commented 7 years ago

@mcverter Look at #190.

mcverter commented 7 years ago

Ah ok. I have been using those css selectors in the backbone.

fabacab commented 7 years ago

Now that #204 is merged I think our next step with the Backbone stuff is to look at the remaining .js files and do the same sort of conversion that we applied to the file in that change set.

I've updated the todo list in this issue to reflect that.