betterbettor / bet-better-server

RESTful API for BetBetter
MIT License
0 stars 0 forks source link

Feat/api init #15

Closed charrrleee closed 11 months ago

charrrleee commented 11 months ago
  1. add db name in db Uri path
  2. Implement Match/Odds/Team Schema
  3. create data model interface of League, match, odds, response, team
  4. implement services of match and odds to connect DB
  5. implement a matchCotroller with putting odds data into match response
krissolui commented 11 months ago

Issues

  1. Express v4 causing error when use promise as RequestHandler. Will upgrade to Express v5 which issue has been fixed. Screenshot 2023-10-17 at 11 05 42
  2. Code is not formatted properly.
krissolui commented 11 months ago

Updates

  1. Upgraded to Express v5 to resolve errors occurring when using promise as RequestHandler.
  2. Formatted all files
  3. Overwritten yarn.lock

Result: no vulnerable dependency found

Screenshot 2023-10-17 at 11 48 49
louvrecly commented 11 months ago

Added three commits to address the comments I've made in the previous review. Here's a summary of the changes:

@krissolui @charrrleee Please feel free to review them and see if any further changes are needed.

krissolui commented 11 months ago
  1. Removed country and season from League interface.
  2. Updated Match interface to use League interface directly.
  3. Changed return code from 500 to 200 for health-check.