Open GoogleCodeExporter opened 8 years ago
Thanks, this patch looks great. I'll merge it after 1.0 release is out
(hopefully
this weekend).
Original comment by romario...@gmail.com
on 18 Nov 2009 at 8:28
ok, then please hold on, i'm working on improving this (select difficulty before
generating, etc)
btw, do you have a coding guide/rules? in the moment i'm just guessing :-)
Original comment by mhelff@gmail.com
on 19 Nov 2009 at 11:00
No, I don't have any explicit coding rules at this point, but it is good idea
to have
one, so here it is ;-) :
http://source.android.com/submit-patches/code-style-guide.
I can give you commit access and create your own branch, let me know if you're
interested in that.
Original comment by romario...@gmail.com
on 23 Nov 2009 at 7:59
instant coding rules :-) ok, i will try to use them.
commit access for a branch would be really nice!
Original comment by mhelff@gmail.com
on 26 Nov 2009 at 12:56
Hi, I've given you commit access. You can commit your changes directly to the
trunk,
I'll review them then.
Original comment by romario...@gmail.com
on 1 Dec 2009 at 8:06
Hi, I've looked again on this patch, there are few problems:
1) It's slow on G1.
2) There are many Java warnings (however it should not be big problem to remove
them).
3) There are some unused pieces of code.
4) I've some doubts about the generated puzzles - I don't see some common
solving
techniques in cz.romario.opensudoku.logic.strategies like X-Wing.
Right now I'm not able to put any time into this, so for now I've removed the
patch
from the trunk.
Original comment by romario...@gmail.com
on 28 Apr 2010 at 8:13
Original issue reported on code.google.com by
mhelff@gmail.com
on 16 Nov 2009 at 10:07Attachments: