Closed Vincent-vst closed 1 year ago
TYSM VINCENT!! You always helping with the project and damn your features are nice. tysm for the PR. for some reason your not appering on the contributors tab... do you know what it could be?
no problem ! I think I messed up my git config
which is why I'm not appearing on the contributor tab.
@Vincent-vst that's bad :( would love to see your profile on contributors...
Why this pr ?
I had a problem when I typed for instance "discord.com/app" (which is valid url) but I wasn't redirected to it (because it didn't start with http), so it just started to google "discord.com/app" which is not what I wanted. In this commits :
browser.tabs.update()
and that fix my problem."https://www.google.com/search?q=" + encodeURIComponent(query);
like before.basically a lot of words for just adding a
if
statementQuoting from the doc :
I had to append
http
to urls that doesn't contain it because firefox extension is not super friendly with "valid urls".Other info
Something that I need to mention is that a query that doesn't start with http* is redirected to
http
nothttps
. For instance : if I typewww.google.com
arcfox will send me tohttp://www.google.com
and then the google server will redirect me tohttps://www.google.com
The reason behind this is that I cannot know in advance if the website is inhttp
orhttps
. More info on this stackoverflow post I made : https://stackoverflow.com/questions/76120582/javascript-convert-hostname-url-into-full-url