Draft doesn't recognize markdown links

robroc commented 3 years ago

*Using Amazon Linux AMI

The drafts created using a markdown template (foia.md) did not recognize markdown links and came out as raw markdown.

Expected behaviour:

nous vous demandons de répondre à CES QUESTIONS avant le 20 août 2021

Actual behaviour:

nous vous demandons de répondre à [CES QUESTIONS](https://docs.google.com/forms/d/e/1FAIpQLSckrqdL8KjFyrpQtB-c62WetoghHQ4-qB64HH0V6SdB5zq1Fw/viewform) avant le 20 août 2021

brandonrobertz commented 3 years ago

~~Did the rest of the markdown conversion work? Did only the link part of the markdown fail? (I'm also assuming you have the latest version of foiamail?)~~

foiamail sends the response email as plain text. Markdown is only used to prepare the PDF. So this is a bug with the strip_markdown function in msg/compose.py

robroc commented 3 years ago

-->I only did markdown with links, so I can’t say if other markdown code worked or failed. Also, yes, I believe I have the latest version. I installed it on EC2 just last month.

From: Brandon RobertsSent: July 27, 2021 4:43 PMTo: bettergov/foiamailCc: Roberto Rocha; AuthorSubject: Re: [bettergov/foiamail] Draft doesn't recognize markdown links (#68) Did the rest of the markdown conversion work? Or just the link part of the markdown failed? (I'm also assuming you have the latest version of foiamail?)

brandonrobertz commented 3 years ago

I only did markdown with links, so I can’t say if other markdown code worked or failed. Also, yes, I believe I have the latest version. I installed it on EC2 just last month. From: Brandon RobertsSent: July 27, 2021 4:43 PMTo: bettergov/foiamailCc: Roberto Rocha; AuthorSubject: Re: [bettergov/foiamail] Draft doesn't recognize markdown links (#68) Did the rest of the markdown conversion work? Or just the link part of the markdown failed? (I'm also assuming you have the latest version of foiamail?)—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

I edited my message (which you probably can't see via email):

~Did the rest of the markdown conversion work? Did only the link part of the markdown fail? (I'm also assuming you have the latest version of foiamail?)~

foiamail sends the response email as plain text. Markdown is only used to prepare the PDF. So this is a bug with the strip_markdown function in msg/compose.py

Currently foiamail only supports plain text emails. Things to try:

using an HTML link
using the DOCX message if you don't want PDF
just putting a plain text URL in your message.
figuring out how to strip links from inside the strip_markdown function inside msg/compose.py

bettergov / foiamail

Draft doesn't recognize markdown links #68