search

bettergui / BeVietnamPro

open source Vietnamese font family for universal professional design
SIL Open Font License 1.1
98 stars 4 forks source link

WinAscent is wrong again #8

Closed RosaWagner closed 2 years ago

RosaWagner commented 2 years ago

The font finally got into sandbox.

In the sources I sent you last time, WinAscent was 1261, and somehow, in the file you sent me to ship to google it is now 1000. So, as discussed, multiple times, it creates clipping in browser: the top of some vietnamese accents are cut. Since use_typo_metrics is now enabled, we don't need typoAscender to equal WinAscent.

I can't send it to production.

Capture d’écran 2021-08-12 à 12 18 46

bettergui commented 2 years ago

Sorry, there must be some misunderstanding. We will look into this and address it within 48 hours.

bettergui commented 2 years ago

Hi Rosa, we are still confused about what happened but we think we got a fix as follows:

  1. We doublechecked what we sent you and verified that all WinAscent had been 1261:

    Screen Shot 2021-08-14 at 2 13 30 AM

  2. The values which were 1000 were actually sTypoAscender:

    Screen Shot 2021-08-14 at 2 08 39 AM

  3. We changed sTypoAscender to 1261, converted the ttx back to ttf, checked with Glyphs, and saw no clippings.

    Screen Shot 2021-08-14 at 2 07 02 AM

We just pushed the changes above: https://github.com/bettergui/BeVietnamPro/commit/10058fd8be4e32b43e5ac17e80faef4c2b67b9da Would you mind helping us check if this works?

RosaWagner commented 2 years ago

You are not supposed to do that with ttx. It means that every time you modify the sources (.glyphs), then you have to do the little trick with ttx, which is not a practical, nor handy for users forking your repo, and result in this kind of confusion. We need a scalable production workflow; which mean no inconsistencies between your sources and your exported fonts. I set it up for you already.

In the masters' information in the source files, this is where the problem is, and this is were it needs to be fixed:

Capture d’écran 2021-08-14 à 12 39 41

When done, then you reexport the fonts (or I do it if needed) with gftools builder as explained in the README.md, and then I ship it.

If the using gftools is somehow too complicated, then I set up a workflow that does it for you automatically whenever you modify the sources.

bettergui commented 2 years ago

We want to do this right, and we appreciate you are helping us do so.

The sources have been fixed, and we have just exported the ttf files using the gftools. We haven't found a good way to test whether this will still be clipped. Can you teach us how to test the result, @RosaWagner ?

Screen Shot 2021-08-14 at 10 54 50 PM

Newest changes have been pushed: https://github.com/bettergui/BeVietnamPro/commit/804e62d81abbbcdcce5686069c69b41b8c245192

yellow-type-foundry commented 2 years ago

@RosaWagner Hi Rosa, do you need any further assistance from us? Hope to solve this soon, thank you!

RosaWagner commented 2 years ago

Hi Sorry i was off for a week. You can just test the font in any browser and see if the glyph that has the tallest bouding-box is clipping. Like using these testing pages: https://idiotproofed.com, https://wakamaifondue.com etc.

Or in Glyphs you have a plugin "show vertical metrics", you can see if the win-metrics are going too low or not.

RosaWagner commented 2 years ago

Our QA tool have a problem since last week, I'll ship the font when it is fixed

yellow-type-foundry commented 2 years ago

That sounds good @RosaWagner Let us know if you need our help!

yellow-type-foundry commented 2 years ago

@RosaWagner Hi Rosa, have you got any update on this?

RosaWagner commented 2 years ago

Yep I shipped and merged it. We can close this issue :)