search

betterphp / MineBans

A global banning system for Minecraft servers that allows the server admin very fine control over the limits for their server
http://minebans.com/
7 stars 0 forks source link

Global ban sais player never connected to the server #14

Open InsaneJ opened 11 years ago

InsaneJ commented 11 years ago

When trying to ban a proven griefer, in this case Wesley_Wilson, Minebans gives the following error: "You cannot globally ban a player that has never connected to the server."

Doing /ban Wesley_Wilson 2 and /ban "Wesley_Wilson" 2 gives the same output. There is a Wesley_Wilson.dat file present in the world\players directory.

Doing a regular /ban Wesley_Wilson bans the player locally. The server logs show no error or output of any kind when issuing a global ban.

Doing /minebans lookup Wesley_Wilson sais there are 0 bans on record.

Another player, diamonddiamond, was successfully banned from one of these servers a few minutes ago and appears on minebans.com.

Running MineBans-1.6-Release on Spigot #903 and #937. Both these servers are behind a BungeeCord proxy setup using BungeeCord #539 and MineBansBungeeCord #6.

betterphp commented 11 years ago

This is an issue with the server implementation, as can be seen here https://github.com/betterphp/MineBans/blob/master/src/main/java/com/minebans/minebans/commands/BanExecutor.java#L139 the plugin just calls the hasPlayedBefore() method which seems to be unreliable for some players.

An issue has been created on the Bukkit issue tracker https://bukkit.atlassian.net/browse/BUKKIT-1220 but never addressed.

InsaneJ commented 11 years ago

Thanks for you reply. That ticket is over a year old so I'm guessing we're just going to have to learn to live with it for now.

At the moment we've issued a local ban on our Lobby server. We've configured Bungeecord so players always have to go through the Lobby server to get to any of the other servers. This seems to be working for now. Except of course that other players and servers don't get the benefit of the global bans this way.

betterphp commented 11 years ago

Yeah I know I'm not very happy with the situation, the plugin already has a workaround so that any player that connected since the last server startup will always work but I'll look into alternatives.