search

betterphp / SimpleIRC

A simple plugin for Bukkit servers that links the in-game chat to an IRC server.
2 stars 3 forks source link

Bot Text Colour in Minecraft #8

Open xavierthompson opened 11 years ago

xavierthompson commented 11 years ago

Hi,

I've been tinkering and found that if bots on two different servers connect to the same channel, cross-server dialogue is possible.

However, bot text gets coloured black.

My attempts to fix this all resulted in the successfully compiled plugin failing to initialise with the error message that the server couldn't read SimpleIRC's build number from string ' '.

What can we/I/you do about this?

Cheers,

Xav

betterphp commented 11 years ago

When my CI builds the plugin it adds the build number to the manifest file, this is used for the new method profiler that I added last week so that I can identify the specific file people are using. The error should be okay to ignore but if you want it to go away set the BUILD_NUMBER environment variable to -1 or something obviously invalid so I can filter it out.

This is assuming I have the right error in mind, the one printed in the catch block here https://github.com/betterphp/BasePlugin/blob/master/src/main/java/uk/co/jacekk/bukkit/baseplugin/BasePlugin.java#L113 ?

The cross-server chat thing is interesting actually, that's sort of a side effect of the way the bots don't know each other. It might be an idea to add some proper support for that in too as well as fixing the colours, so something like being able to define the bot names so that messages don't show up in game as being from the bot exactly. Maybe in-game only server prefixes.

xavierthompson commented 11 years ago

Thanks for your response, much appreciated. That is indeed the error I am receiving.

Before I start looking, where can I edit the BUILD_NUMBER env variable? I'm currently building using maven, hope that is correct.

If you ever need me to test this cross-server functionality, just drop me a line, happy to tap it in and give you some feedback.

Regards,

Xavier

betterphp commented 11 years ago

If you use Eclipse you can set env variables for the build process via the Run configurations menu http://jacekk.co.uk/screenshots/2013-05-30_13:36:35.png

You could also edit the META-INF/manifest.mf file manually to set the build number to something other than an empty string.

xavierthompson commented 11 years ago

Cheers mate, I'll look into it on my next day off.