bettersg / checkMate

GNU General Public License v3.0

5 stars 0 forks source link

Feature/checkers app onboarding #238

Closed btjl closed 3 months ago

btjl commented 5 months ago

Constantly updating this section until this PR is merged in

Features:

[x] Firebase functions / firestore link up to page - Using Tanstack Query
[x] Routing based on factChecker document isOnboardingComplete field
[x] Onboarding page. - Static information + Link to Typeform
[x] Acknowledgement by user + Updating of factChecker in firestore

Post schema change (94ce41c)

[x] Update authentication to work with App.tsx
[x] Utilise the already created postChecker.ts to create a new checker in firestore

Success criteria 1:

New user opens Webapp for the first time. Sees onboarding screen. Fills up the name and addresses the onboarding questions. Submit at the last step. Redirected to dashboard page + (system) New checker entity is added to Firestore

Success criteria 2:

Existing user opens Webapp. Redirected to dashboard page.

btjl commented 5 months ago

Hi guys! The MVP for onboarding page is done!

Possible enhancement to be made include a simple validation for the factChecker's name input with a corresponding error message.

More validation on each step to explicitly check if a user has read a link via a checkbox. But this may require quite a bit of refactoring to manage this state within the parent onboarding page component.

btjl commented 4 months ago

Success criteria 1:

New user opens Webapp for the first time.
Sees onboarding screen.
Fills up the name and addresses the onboarding questions.
Submit at the last step.
Redirected to dashboard page + (system) New checker entity is added to Firestore

Success criteria 2:

Existing user opens Webapp.
Redirected to dashboard page.

btjl commented 4 months ago

The recent changes to develop has had some impact on this PR due to the schema changes

functions/src/api/authentication.ts
functions/src/api/api.ts

Looking into resolving them

btjl commented 4 months ago

@sarge1989 , post commit id 94ce41c where I merged develop into this branch, I think this PR is also being used by @madanalogy to input his comments on the Feature/llm agent merge request - https://github.com/bettersg/checkMate/pull/240

btjl commented 3 months ago

Marking as duplicate of https://github.com/bettersg/checkMate/pull/252 that was merged into the main development (develop) branch.