search

bettiolo / oauth-signature-js

JavaScript OAuth 1.0a signature generator (RFC 5849) for node and the browser
https://www.npmjs.com/package/oauth-signature
BSD 3-Clause "New" or "Revised" License
232 stars 71 forks source link

Variable name "url" in my script conflicts with url.min.js #14

Open ghost opened 8 years ago

ghost commented 8 years ago

Web Console (Firefox): "TypeError: url is not a function" (I'm using "url2" in my script now to get it to work.)

bettiolo commented 8 years ago

Currently we are using js-url to parse urls in the browser, we would need to avoid using globals: https://github.com/bettiolo/oauth-signature-js/blob/master/src/app/oauth-signature.js#L92-L97 In the highlighted code url is global.

We could inline url parsing logic to solve this issue.