So I just ran into #9 myself. I think @jmendiara has it a little mixed up in his example. Because of this line, if you were to generate a signature with parameters such as the following:
var params = {
from: 0,
another: false,
to: 1
};
The signature base string would include something like: http://foo.com/bar?from=&another=&to=1 instead of http://foo.com/bar?from=0&another=false&to=1.
Without this, the user of the library would have to be mindful in always converting parameter values to strings. I also added tests so this fixes #9.
So I just ran into #9 myself. I think @jmendiara has it a little mixed up in his example. Because of this line, if you were to generate a signature with parameters such as the following:
The signature base string would include something like:
http://foo.com/bar?from=&another=&to=1
instead ofhttp://foo.com/bar?from=0&another=false&to=1
.Without this, the user of the library would have to be mindful in always converting parameter values to strings. I also added tests so this fixes #9.
Any plans on upgrading
uri-js
for #34 #35 #38?