Closed jmendiara closed 6 years ago
Sorry, I have no time for making test
Hi @jmendiara, The comment I wrote for the issue #10 answers this as well: https://github.com/bettiolo/oauth-signature-js/issues/10#issuecomment-56973402
Please, tell me if this clarifies the situation.
This is a matter of parameter serialization, not RFC stuff. If I want to send
GET http://foo.com/bar?from=0&to=1&oauthStuff
I would need to encode the parameters this way
var params = {
from: '0',
to: 1
};
oauthSignature.generate(..., params, ....);
otherwise, the server signature will fail cause of you signed the url
GET http://foo.com/bar?from=&to=1&oauthStuff
Cause falsy permissive comparisons, all falsy values are considered
''
when computing the signatureThis PR solves the
false
and0
use case, following the same approach used fortrue
andNumber
, creating an URL