search

bettybop68 / android-rcs-ims-stack

Automatically exported from code.google.com/p/android-rcs-ims-stack
0 stars 1 forks source link

Media session handling #177

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Until release 2.5.5 the ACK was sent immediately after receiving a 200OK in an 
originating session. This was changed with release 2.5.6 in a way that now the 
ACK is only sent after the media session is set up.

Could you please share some reason why it was changed. From my perspective the 
ACK is just confirming the 200OK and should be sent out immediately.
shouldn't the ACK be sent immediately instead of waiting for the media session 
to be established ?

Original issue reported on code.google.com by benoit.j...@gmail.com on 4 Nov 2013 at 2:48

GoogleCodeExporter commented 8 years ago 
We had made this modification for the 'restart' case of a group chat,
In this case, a text message can be sent immediately after the start of the 
session. And  handleSessionStarted is before startMediaSession, then, the MSRP 
session must be ready…
But, we can have an issue if the server waits the ACK to create the msrp 
connection…

Original comment by benoit.j...@gmail.com on 4 Nov 2013 at 2:48

GoogleCodeExporter commented 8 years ago 
I've changed the code to achieve both: sending ACK immediately and don't flag a 
session as started before media is setup. Please have a look at Trello.

Original comment by RCSe...@googlemail.com on 6 Nov 2013 at 1:40

GoogleCodeExporter commented 8 years ago 
Done in V2.5.13

Original comment by benoit.j...@gmail.com on 7 Nov 2013 at 4:42