search

bevacqua / angularjs-dragula

:ok_hand: Drag and drop so simple it hurts
https://bevacqua.github.io/angularjs-dragula
MIT License
509 stars 109 forks source link

Sourcemapping Interference #42

Closed janewang closed 8 years ago

janewang commented 8 years ago

Hi @bevacqua, you've included your own sourcemap on L1121 in dist/angular-dragula.js and it is interfering with our sourcemap. We'd suggest that you remove this sourcemap and allow the users to determine how they would like to build their own code.

bevacqua commented 8 years ago

If you want to build your own distribution you're welcome to compile angular-dragula via browserify like in the build task.

thetrevdev commented 8 years ago

I second this. We also receive issues with the sourcemaps if we concatenate this as a dependency.

bevacqua commented 8 years ago

Again, you're welcome to compile angular-dragula via browserify like in the build task. The dist files aren't changing -- they only exist to provide convenience, they're not meant for advanced uses.

thetrevdev commented 8 years ago

Thats not a very good solution. That is a process we would have to do on each version bump so we can try and get bug fixes. Ideally we could bower install angular-dragula. Concatenate our application and be good to go. Instead we get a bundle that has an incorrect sourcemap when concatenated.
*This being said I realize that concatenating scripts is not the right solution but its what our old legacy system uses. Manually removing the sourcemapping from the distributable for now.