bevacqua / dragula

:ok_hand: Drag and drop so simple it hurts
https://bevacqua.github.io/dragula/
MIT License
21.89k stars 1.97k forks source link

Changes the button detect mechanism in function whichMouseButton. #542

Closed januslo closed 6 years ago

januslo commented 6 years ago

dragula is so great the lost of the libs refers. However some logic just drive me crazy, such as the button detect mechanism in function whichMouseButton. I found it at dragular and that make things not work at chrome ( 63.0.3239.84 64bit mac) & crosswalk 19+,so provides a change and thing goes will. However, today, few months later, I found that issue exits at another lib "ng2-dragular" and cause the same impacts, so maybe more libs would just refer dragula and may faces the same "problem". Plz refer this discuss before and accept my pull request.

https://github.com/luckylooke/dragular/issues/125

Thx & Great Job

januslo commented 6 years ago

self-reviews the changes