search

bevacqua / dragula

:ok_hand: Drag and drop so simple it hurts
https://bevacqua.github.io/dragula/
MIT License
21.89k stars 1.97k forks source link

[Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. #644

Open amk221 opened 4 years ago

amk221 commented 4 years ago

Steps to re-create

  1. Visit the dragula demo site
  2. Open the Chrome inspector
  3. Switch to a mobile device emulator
  4. Drag something
  5. See console message

Screen Recording 2020-06-09 at 11 49 am

Yokubjon-J commented 4 years ago

Hello! I am a first-timer. Can I pick this issue up?

amk221 commented 4 years ago

Amazing, I don't think anyone would stop you!

But, seeing as though there hasn't been a release since 2016, who knows if it would ever make it in!

Yokubjon-J commented 4 years ago

Thanks for replying! I have started working on it! Do you mean it can be hard by "who knows if it would ever make it in!"?

amk221 commented 4 years ago

Great!

Nope, not at all, just that, I don't know who would merge it into master & release it, as it seems to be unmaintained.

Yokubjon-J commented 4 years ago

It is saddening that this library is being abandoned. But anyway I hope, once I am done with the issue, someone will merge it.

Yokubjon-J commented 4 years ago

@amk221 Hello! I have created a pull request for the problem! I hope my fix will work!

dcantatore commented 3 years ago

@Yokubjon-J

I would like to merge this in but I am unable to duplicate it on my actual mobile device. Can you test on an android device and see if it is an issue? If so please provide a video or screen shot and I will merge it in. Thanks