search

bevacqua / rome

:calendar: Customizable date (and time) picker. Opt-in UI, no jQuery!
https://bevacqua.github.io/rome
MIT License
2.91k stars 223 forks source link

Stop 'hide' event from firing when calendar is already hidden #116

Closed codekipple closed 9 years ago

codekipple commented 9 years ago

Added check to hideCalendar() function to avoid calling the hide event when the calendar was already hidden.

Without this the hide event is called every time the user clicks the mouse.

codekipple commented 9 years ago

See issue #91

bevacqua commented 9 years ago

Cool. Additionally we should probably move to using CSS classes rather than hardcoded styles.

codekipple commented 9 years ago

Yes that would be a good idea. Toggling a class both on the datepicker and the associated element.

bevacqua commented 9 years ago

Want to create a PR for that too? Just needs to move the styles to the stylus file and use class names instead of inline styles

codekipple commented 9 years ago

Ok I'll have a look at it. I'm going to give 'free navigation' a go first, you mention here #105 as that's the thing I need at the moment on the website I'm building.

bevacqua commented 9 years ago

Sweet. Thanks for putting work in for rome :)

codekipple commented 9 years ago

Would you be interested in a pull request adding watchify to the gulp setup? I've just added it for myself to speed up builds when working.

It makes a big difference making a change on watch of the js builds in about 0.15 seconds as opposed to 5 seconds. Also the gulp file might benefit from sectioning up a bit with comments.

bevacqua commented 9 years ago

Sure.