search

bevacqua / rome

:calendar: Customizable date (and time) picker. Opt-in UI, no jQuery!
https://bevacqua.github.io/rome
MIT License
2.91k stars 223 forks source link

.destroy().restore() and .options() methods don't work on inline calendar #126

Open jordangarside opened 9 years ago

jordangarside commented 9 years ago

When I do an inline calendar, with either default or custom options, both the options method and the destroy then restore methods result in an empty rd-container.

andrey-hohlov commented 8 years ago

It works in v2.1.3, but broken from 2.1.4

I think reason there: https://github.com/bevacqua/rome/commit/78686fd3de8d50a8f3d1ce1600338a02249c9847

oskarkrawczyk commented 8 years ago

Just bumped into this issue. Interesting that it hasn't been addressed in all these releases.

paddy01 commented 6 years ago

Still an issue in 2.1.22 .. tried reverting some of the changes in specific to the inline calendar #https://github.com/bevacqua/rome/commit/78686fd3de8d50a8f3d1ce1600338a02249c9847 but made no difference to the issue :(

jmirmina commented 5 years ago

We ran into this issue as well. We were able to get around it by specifying the appendTo option and chaining show():

var element = document.getElementById('myContainer'),
    picker = rome(element);

picker.options({ appendTo: element }).show();