search

bevacqua / rome

:calendar: Customizable date (and time) picker. Opt-in UI, no jQuery!
https://bevacqua.github.io/rome
MIT License
2.91k stars 223 forks source link

`undef is not defined` when bundling with rollup #176

Closed joews closed 3 years ago

joews commented 7 years ago

When rome is bundled with rollup, the bundle throws this error on execution:

dist.js:5671 Uncaught ReferenceError: undef is not defined
    at dist.js:5671
    at commonjsGlobal (dist.js:4)
    at dist.js:5
(anonymous) @ dist.js:5671
commonjsGlobal @ dist.js:4
(anonymous) @ dist.js:5

This is caused by a bug in ticky, which is a transitive dependency from contra.

It doesn't happen when bundled with browserify because process is polyfilled, which results in a different ticky code path.

It can be fixed by depending on a new version of contra, which uses a patched version of ticky.