bevacqua / rome

:calendar: Customizable date (and time) picker. Opt-in UI, no jQuery!
https://bevacqua.github.io/rome
MIT License
2.91k stars 223 forks source link

"styles" configuration should not be used for internal lookup #189

Open foobear opened 5 years ago

foobear commented 5 years ago

When using the styles configuration option, I have to be very careful to not break Rome internals. Apparently, configured class names are also used for internal logic to find elements in the picker.

Examples:

I've created a pen for both: https://codepen.io/foobear/pen/NmqOGG

knorthfield commented 5 years ago

Adding classes to timeOption or dayBodyElem also disables ability to pick a date or time.