search

bevacqua / rome

:calendar: Customizable date (and time) picker. Opt-in UI, no jQuery!
https://bevacqua.github.io/rome
MIT License
2.91k stars 223 forks source link

Added autoCloseDay and autoCloseTime options #76

Closed MitMaro closed 9 years ago

MitMaro commented 9 years ago

Added autoCloseDay and autoCloseTime options that will close Rome only day or time change respectively.

If there are any changes that can be made I will gladly update.

bevacqua commented 9 years ago

Rather than adding more options, I was hoping to add more values for the autoClose option.

MitMaro commented 9 years ago

Would setting to true also make it always close when time is selected, even if there is a day picker. Currently it only closes on time when there is no day picker.

bevacqua commented 9 years ago

Leave true and false behavior as-is

MitMaro commented 9 years ago

Updated.

bevacqua commented 9 years ago

Let's remove the 'day' option (it's actually the same as true). You can reword the documentation as:

When set to true, the calendar is closed when picking a day (or a time if time: true and date: false) . A value of time will only close the calendar when a time is picked.

MitMaro commented 9 years ago

I didn't like that duplication myself. Updated.

bevacqua commented 9 years ago

Thank you. Released as 2.1.0

MitMaro commented 9 years ago

Thanks!