search

bevacqua / woofmark

:dog2: Barking up the DOM tree. A modular, progressive, and beautiful Markdown and HTML editor
https://bevacqua.github.io/woofmark
MIT License
1.62k stars 74 forks source link

readme fix and upload response handler option #31

Closed jywarren closed 8 years ago

jywarren commented 8 years ago

Fixed #29 readme parameter reversal for runCommand.

Proposed solution for #30 -- what do you think; it makes a specifiable handler for upload responses, as:

images: {
  handleResponse: function (err, res, body) {
    // stuff
  }
}

Alternatively, we could run handleResponse as-is, but insert a response filterer on line 180, before body.href and body.title are used. Depends on how flexible it should be.

bevacqua commented 8 years ago

Let's deal with the image upload in a different branch/PR

jywarren commented 8 years ago

Great, apologies for the typos, have been working on the road and got sloppy. Moved readme changes to #32, closing and reopening this in #33.