bevacqua / woofmark

:dog2: Barking up the DOM tree. A modular, progressive, and beautiful Markdown and HTML editor
https://bevacqua.github.io/woofmark
MIT License
1.62k stars 74 forks source link

GFM Tables do not work properly #4

Closed styfle closed 9 years ago

styfle commented 9 years ago

First of all, woofmark looks awesome! I think this would work great with our app.

I found a bug with tables however. Here are the steps to reproduce on the demo page http://bevacqua.github.io/woofmark/

Click markdown icon and paste the following

| col1 | col2 | col3 |
|------|------|------|
| foo  | bar  | baz  |
| food | bars | bats |

Click wysiwyg icon and you'll see a table (woohoo!) but without borders (boo)

col1 col2 col3
foo bar baz
food bars bats

Click html icon and you'll see proper html table (woohoo!)

<table>
<thead>
<tr><th>col1</th><th>col2</th><th>col3</th></tr>
</thead>
<tbody>
<tr><td>foo</td><td>bar</td><td>baz</td></tr>
<tr><td>food</td><td>bars</td><td>bats</td></tr>
</tbody>
</table>

Now click markdown icon and you'll get paragraphs?? (oops)

col1col2col3

foobarbaz

foodbarsbats

I'm assuming the html -> markdown doesn't support tables yet?

styfle commented 9 years ago

From the docs this sounds like the issue might be in domador maybe.

bevacqua commented 9 years ago

Yeah, please report this on domador. Thanks

jywarren commented 8 years ago

Closed in domador: https://github.com/bevacqua/domador/issues/1 but I'm still seeing tables get munged when I go HTML > Markdown > HTML > Markdown (probably only the last 3 are necessary). Is this fix already integrated; i.e. is woofmark now depending on the fixed domador?

Thanks, woofmark is awesome!