search

bevingtona / planetR

(early development) R tools to search, activate and download satellite imagery from the Planet API.
Apache License 2.0
45 stars 14 forks source link

remove doy limitation #6

Closed tnelsen closed 2 years ago

tnelsen commented 3 years ago

The API is only going to return images between the date_start and the date_end so the limit by doy is repetitive. The function also doesn't have inputs for doy so fails unless there is are doy variables in the Global Environment.

bevingtona commented 3 years ago

Thanks for the PR and sorry for the delayed response! Not sure I understand. The response_doy makes it so that you can filter the day of year of the imagery you actually download (for example only summer). I am rarely interested in grabbing the entire year of imagery, but rather images within a DOY range over many years. Perhaps I am missing something,.. thanks! :)

tnelsen commented 3 years ago

Agreed, but don't you already have a filter in place for a time period of interest when you search for a certain date range? This seems repetitive. Plus, it doesn't work within the function unless you first create day of year variables and save them in your global environment (they aren't inputs to the function nor are they created within the function).