bevry / cson

CoffeeScript-Object-Notation. Same as JSON but for CoffeeScript objects.
Other
1.34k stars 56 forks source link

package.json node engine >=0.8 might be incorrect #68

Closed jspiro closed 8 years ago

jspiro commented 8 years ago

When you're on an older version of node, say 0.10.40, and you load cson:

node_modules/cson/node_modules/extract-opts/node_modules/typechecker/es6/lib/typechecker.js:29
        for ( let type of types ) {

So one of the subdependencies needs es6. Despite this, it seems like cson works in older nodes, just with an error above.

Not sure what the correct solution is since I'm not the maintainer.

balupton commented 8 years ago

Hey thanks for this.

It's a warning that shouldn't be outputted, hence why it is not present in 0.12 despite 0.12 not supporting it anyway. Will work anyway.

The fix has already been pushed to the latest typechecker (which now uses the esnextguardian package), the extract-opts package needs to be updated, I'll focus it on my next todo.

Currently having some personal matters to attend to this week, so will aim for next week.

Cheers.

balupton commented 8 years ago

Changes for this:

  1. https://github.com/bevry/extract-opts needs to be updated for our latest base files and esnextguardian — this is a planned change anyway and will re-add 0.10 support.
  2. For 0.8 support, https://github.com/bevry/typechecker/blob/master/package.json and https://github.com/bevry/esnextguardian/blob/master/package.json need to be changed to node >= 0.8 — whether or not they can still run on node 0.8 is a different question, as it is hard to test on that environment as a lot of dev deps these days don't support that environment. I'm happy dropping 0.8 support for these reasons.

I wish npm actually gave data on their website about which percentage of node version categories (0.8, 0.10, 4, 5) are actually installing your deps.

balupton commented 8 years ago

/ref https://github.com/bevry/cson/pull/69

balupton commented 8 years ago

I've updated extract-opts to once again work on node 0.10, and added explicit tests for 0.10 compat

balupton commented 8 years ago

Will drop 0.10 support. It will be up to the user to include the babel polyfill for environments less than node 0.12. See bevry/base#20 for details.