bevry / dorothy

🧙🏻‍♀️ Bring your dotfile commands and configuration to any shell. Sensible defaults and hundreds of commands preloaded. Supports Bash, Zsh, Fish, Nu, Xonsh, Elvish, Dash, KornShell, macOS, Linux, Windows.
Other
277 stars 21 forks source link

Suggestion: nocolor fallbacks for echo-style / enable color for github actions #187

Closed balupton closed 7 months ago

balupton commented 8 months ago

Since implementing https://github.com/bevry/dorothy/commit/3b85eb173090da873241cec86526428b9f0343ce which disables TTY on "dumb" terminals, the colors on GitHub Actions have been disabled, which makes reading the logs very difficult. GitHub Actions actually does support rendering colors, despite being a dumb terminal.

The solution here is either to revamp echo-style with plenty of nocolor fallbacks (a good thing to do in general), or to have is-color-enabled check for GitHub Actions and enable colors (a quick fix).