search

bevry / dorothy

🧙🏻‍♀️ Bring your dotfile commands and configuration to any shell. Sensible defaults and hundreds of commands preloaded. Supports Bash, Zsh, Fish, Nu, Xonsh, Elvish, Dash, KornShell, macOS, Linux, Windows.
Other
311 stars 22 forks source link

fix editor selection in Dorothy command for vscode #199

Closed wasdee closed 8 months ago

balupton commented 9 months ago

Strange this was necessary for you.

Without a --gui or --terminal flag, it should autodetect based on whether our environment is desktop or headless. For instance, if we are sshing into a desktop machine target, we don't want to open vscode on the target.

The change of else to else if, is also surprising, as from memory it should be only one or the other; I could be wrong here though, as could be some exceptions.

I'm guessing the autodetection did not work.

Which desktop and terminal were you using?

wasdee commented 9 months ago

this is what i got after dorothy edit it ran nano. image image

context

wasdee commented 9 months ago

Strange this was necessary for you.

Without a --gui or --terminal flag, it should autodetect based on whether our environment is desktop or headless. For instance, if we are sshing into a desktop machine target, we don't want to open vscode on the target.

The change of else to else if, is also surprising, as from memory it should be only one or the other; I could be wrong here though, as could be some exceptions.

I'm guessing the autodetection did not work.

Which desktop and terminal were you using?

maybe it detect that im on a ssh

balupton commented 9 months ago

Ahhh, yeah that will be it. Should be easy to reproduce, I'll fix it up when I get home.