bevry / dorothy

🧙🏻‍♀️ Bring your dotfile commands and configuration to any shell. Sensible defaults and hundreds of commands preloaded. Supports Bash, Zsh, Fish, Nu, Xonsh, Elvish, Dash, KornShell, macOS, Linux, Windows.
Other
277 stars 21 forks source link

Bug: `interactive.sh` is loaded even when `interactive.fish` exists #222

Closed edmcman closed 2 months ago

edmcman commented 2 months ago

From README.md:

Fish will load interactive.fish if it exists, otherwise it will load interactive.sh.

This doesn't seem to be the current behavior:

hello from interactive.fish
hello from interactive.sh
Thank you to Dorothy contributor 🤍 Sumit Rai 🔗 https://github.com/sumitrai
Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish
ed@banana ~> 

I put echo "hello from X" into $DOROTHY/config/X

This is problematic because I was trying to add some POSIX stuff to interactive.sh that fish doesn't like.

balupton commented 2 months ago

Will look into it over the next 5 hours.

balupton commented 2 months ago

This was an instance where the documentation differed from the implementation. The documentation is the intended behaviour.

I have a fix incoming, just need to implement it for elvish and xonsh as well.

balupton commented 2 months ago

Fix out, you can run dorothy update to get it.

edmcman commented 2 months ago

Thanks!