search

bevry / dorothy

🧙🏻‍♀️ Bring your dotfile commands and configuration to any shell. Sensible defaults and hundreds of commands preloaded. Supports Bash, Zsh, Fish, Nu, Xonsh, Elvish, Dash, KornShell, macOS, Linux, Windows.
Other
277 stars 21 forks source link

Bug: Dorothy sets CC to '' #224

Closed edmcman closed 2 months ago

edmcman commented 2 months ago

On my machine, dorothy is setting CC and related build variables to an empty string. This causes some tools to do silly things like:

   -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -fPIC -DPACKAGE=jep -DUSE_DEALLOC=1 -DJEP_NUMPY_ENABLED=0 -DVERSION=\"4.2.0\" -DPYTHON_LDLIBRARY=\"libpython3.10.so\" -I/usr/lib/jvm/temurin-17-jdk-amd64/include -I/usr/lib/jvm/temurin-17-jdk-amd64/include/linux -Isrc/main/c/Include -Ibuild/include -I/home/ed/Ghidra/venv/include -I/usr/include/python3.10 -c src/main/c/Jep/convert_j2p.c -o build/temp.linux-x86_64-cpython-310/src/main/c/Jep/convert_j2p.o
      error: command '-Wno-unused-result' failed: No such file or directory
      [end of output]

These variables should probably be unset by default instead...

balupton commented 2 months ago

Here's the culprit: https://github.com/bevry/dorothy/blob/2da8d15d23fd1839815c0fe8ae72a21f74278982/commands/setup-environment-commands#L108

I'll change it to only export it when we have a value for it.